Summary: | Define the type of SVGPropertyOwnerRegistry for all SVG elements | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||
Component: | SVG | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, rniwa, simon.fraser, thorton, webkit-bug-importer, zimmermann | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 191237, 195862 | ||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2019-03-16 23:44:05 PDT
Created attachment 364960 [details]
Patch
Comment on attachment 364960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364960&action=review > Source/WebCore/svg/SVGFEBlendElement.h:71 > + using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEBlendElement, SVGFilterPrimitiveStandardAttributes>; > + const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; } > + > + static bool isKnownAttribute(const QualifiedName& attributeName) > + { > + return AttributeOwnerProxy::isKnownAttribute(attributeName) || PropertyRegistry::isKnownAttribute(attributeName); > + } Lots of classes have this same boilerplate. Can it be pushed to a base class? Comment on attachment 364960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364960&action=review >> Source/WebCore/svg/SVGFEBlendElement.h:71 >> + } > > Lots of classes have this same boilerplate. Can it be pushed to a base class? It is a static function which uses different types of AttributeOwnerProxy and PropertyRegistry so it can't be virtual. But it will go away once the tear-off objects are removed. Created attachment 365083 [details]
Patch
Comment on attachment 365083 [details] Patch Clearing flags on attachment: 365083 Committed r243114: <https://trac.webkit.org/changeset/243114> All reviewed patches have been landed. Closing bug. |