Bug 195859 – Define the type of SVGPropertyOwnerRegistry for all SVG elements

• Component: SVG
• Status: RESOLVED FIXED

[Said Abou-Hallawa]

SVGPropertyOwnerRegistry will eventually replace SVGAttributeOwnerProxyImpl.

[Said Abou-Hallawa]

Created attachment 364960 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 364960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364960&action=review

> Source/WebCore/svg/SVGFEBlendElement.h:71
> +    using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEBlendElement, SVGFilterPrimitiveStandardAttributes>;
> +    const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
> +
> +    static bool isKnownAttribute(const QualifiedName& attributeName)
> +    {
> +        return AttributeOwnerProxy::isKnownAttribute(attributeName) || PropertyRegistry::isKnownAttribute(attributeName);
> +    }

Lots of classes have this same boilerplate. Can it be pushed to a base class?

[Said Abou-Hallawa]

Comment on attachment 364960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364960&action=review

>> Source/WebCore/svg/SVGFEBlendElement.h:71
>> +    }
> 
> Lots of classes have this same boilerplate. Can it be pushed to a base class?

It is a static function which uses different types of AttributeOwnerProxy and PropertyRegistry so it can't be virtual. But it will go away once the tear-off objects are removed.

[Said Abou-Hallawa]

Created attachment 365083 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365083 [details]
Patch

Clearing flags on attachment: 365083

Committed r243114: <https://trac.webkit.org/changeset/243114>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48999640>