Bug 195857

Summary:

ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in _doubleTapDidFail:

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Dean Jackson 2019-03-16 14:37:30 PDT

ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in _doubleTapDidFail:

Comment 1 Dean Jackson 2019-03-16 14:38:02 PDT

<rdar://problem/48954679>

Comment 2 Dean Jackson 2019-03-16 14:42:19 PDT

Created attachment 364942 [details]
Patch

Comment 3 Wenson Hsieh 2019-03-16 14:47:41 PDT

Comment on attachment 364942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364942&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:652
> +        [_doubleTapGestureRecognizer setGestureFailedTarget:self action:nil];

Nit - Is there a reason we prefer setting the target to self instead of nil?

Comment 4 Dean Jackson 2019-03-16 15:04:35 PDT

Committed r243047: <https://trac.webkit.org/changeset/243047>