| Summary: | [JSC] jsSubstring should resolve rope before calling JSRopeString::create | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2019-03-15 18:07:57 PDT
Created attachment 364895 [details]
Patch
Created attachment 364898 [details]
Patch
Created attachment 364899 [details]
Patch
Comment on attachment 364899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364899&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + We can find that a lot of substrings for length = 1 are allocated in RAMification regexp tests. This patch avoids creation of these How much memory does this patch save? Comment on attachment 364899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364899&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + We can find that a lot of substrings for length = 1 are allocated in RAMification regexp tests. This patch avoids creation of these > > How much memory does this patch save? It shows (patched) 34938880 v.s. (tot) 36163584 in non-JIT regexp, 3.5%. Committed r243081: <https://trac.webkit.org/changeset/243081> |