| Summary: | Web Inspector: Canvas: rework how Canvas.enable/Canvas.disable is used so that events are not sent when the Canvas tab isn't enabled | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, rniwa, timothy, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 175485 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Devin Rousso
2019-03-15 15:43:07 PDT
Created attachment 364860 [details]
Patch
Created attachment 364861 [details]
Patch
Forgot to clear the maps :(
Comment on attachment 364861 [details] Patch Attachment 364861 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11524049 New failing tests: inspector/canvas/setRecordingAutoCaptureFrameCount.html inspector/canvas/resolveCanvasContext-bitmaprenderer.html inspector/canvas/recording-2d.html inspector/canvas/recording-webgl.html inspector/canvas/requestContent-webgl2.html inspector/canvas/updateShader.html inspector/canvas/resolveCanvasContext-webgl2.html inspector/canvas/resolveCanvasContext-webmetal.html inspector/canvas/create-context-bitmaprenderer.html inspector/canvas/resolveCanvasContext-2d.html inspector/canvas/setShaderProgramDisabled.html inspector/canvas/extensions.html inspector/canvas/recording-bitmaprenderer.html inspector/canvas/resolveCanvasContext-webgl.html inspector/canvas/requestContent-webgl.html inspector/canvas/requestContent-2d.html inspector/canvas/create-context-webgl.html inspector/canvas/recording.html inspector/canvas/setShaderProgramHighlighted.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/requestShaderSource.html inspector/canvas/memory.html inspector/canvas/requestContent-bitmaprenderer.html inspector/canvas/requestNode.html Created attachment 364877 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 364883 [details]
Patch
Comment on attachment 364883 [details] Patch Clearing flags on attachment: 364883 Committed r243272: <https://trac.webkit.org/changeset/243272> All reviewed patches have been landed. Closing bug. |