Bug 195828

Summary: Web Inspector: Canvas: rework how Canvas.enable/Canvas.disable is used so that events are not sent when the Canvas tab isn't enabled
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, drousso, ews-watchlist, inspector-bugzilla-changes, rniwa, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 175485    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews103 for mac-highsierra
none
Patch none

Description Devin Rousso 2019-03-15 15:43:07 PDT
If the Canvas tab isn't even "on", we shouldn't send any events to the frontend.
Comment 1 Radar WebKit Bug Importer 2019-03-15 15:43:24 PDT
<rdar://problem/48941756>
Comment 2 Devin Rousso 2019-03-15 15:50:51 PDT
Created attachment 364860 [details]
Patch
Comment 3 Devin Rousso 2019-03-15 15:52:33 PDT
Created attachment 364861 [details]
Patch

Forgot to clear the maps :(
Comment 4 EWS Watchlist 2019-03-15 16:39:17 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2019-03-15 16:39:18 PDT Comment hidden (obsolete)
Comment 6 Devin Rousso 2019-03-15 17:07:23 PDT
Created attachment 364883 [details]
Patch
Comment 7 WebKit Commit Bot 2019-03-20 19:27:40 PDT
Comment on attachment 364883 [details]
Patch

Clearing flags on attachment: 364883

Committed r243272: <https://trac.webkit.org/changeset/243272>
Comment 8 WebKit Commit Bot 2019-03-20 19:27:42 PDT
All reviewed patches have been landed.  Closing bug.