Bug 195826

Summary: [iOS] Modalify <select> popover; app key commands should not be recognized when popover is open
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED WONTFIX    
Severity: Normal CC: bfulgham, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, PlatformOnly
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
Attachments:
Description Flags
Patch
none
Patch none

Description Daniel Bates 2019-03-15 15:23:14 PDT 
Seen on iPad.

Steps to reproduce:

1. Visit <data:text/html,<select><option>First</option><option>Second</option></select>>.
2. Tap the popup button to open the popover.
3. Press Command + r.

Safari reloads the page! But that is not intuitive and does not match the Mac. Instead the popover should behave like a modal and all key events should go it or we need to make the illusions of this.
Comment 1 Radar WebKit Bug Importer 2019-03-15 15:38:00 PDT 
<rdar://problem/48941551>
Comment 2 Daniel Bates 2019-03-15 16:02:57 PDT 
Created attachment 364871 [details]
Patch
Comment 3 Daniel Bates 2019-03-15 16:06:36 PDT 
Created attachment 364874 [details]
Patch
Comment 4 Brent Fulgham 2019-03-18 21:23:07 PDT 
Comment on attachment 364874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364874&action=review

Did we still want to do this? From our earlier discussion I thought modal select was not the desired UI?

> Source/WebKit/ChangeLog:8
> +        Fake it til you make it ð Add a hack to give the illusion that popovers are modal and all

Did you mean to include that non-ASCII character in this line?
Comment 5 Daniel Bates 2019-03-19 11:26:52 PDT 
Comment on attachment 364874 [details]
Patch

No need to fake what you won't make.😀
Comment 6 Brent Fulgham 2019-03-19 12:43:17 PDT 
We decided not to modality <select>.