Bug 195792

Summary:

REGRESSION(cairo-1.17.2) GraphicsContext::clipRoundedRect clips everything

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

don.olmstead

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
repro	none
simple cairo clipping program	none

Fujii Hironori

Reported 2019-03-14 20:40:42 PDT

Created attachment 364766 [details] repro [WinCairo] Texts are not drawn in blocks with border-radius and overflow-x:auto Testing with WinCairo port trunk@242984 WK1 and WK2 BrowerWindow. It seems that GTK port doesn't have this issue.

Attachments
repro (150 bytes, text/html) 2019-03-14 20:40 PDT, Fujii Hironori	no flags	Details
simple cairo clipping program (5.61 KB, text/plain) 2019-03-18 00:33 PDT, Fujii Hironori	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-03-14 22:50:58 PDT

https://stackoverflow.com/questions/55176294/ https://www.apple.com/shop/buy-iphone/iphone-8 https://blog.tomoya.dev/2019/01/emacs-auto-fix/ https://qiita.com/michaelyuki0908/items/75a9c9f9e358f3582308

Don Olmstead

Comment 2 2019-03-17 20:52:30 PDT

Does it work with the previous cairo?

Fujii Hironori

Comment 3 2019-03-17 21:10:57 PDT

This issue can be fixed by replacing with cairo.dll of WinCairoRequirements v2018.11.27 (Cairo 1.16.0).

Fujii Hironori

Comment 4 2019-03-17 21:13:00 PDT

GraphicsContext::clipRoundedRect doesn't work as expected.

Fujii Hironori

Comment 5 2019-03-18 00:33:22 PDT

Created attachment 365003 [details] simple cairo clipping program

Fujii Hironori

Comment 6 2019-03-18 01:10:37 PDT Comment hidden (obsolete)

I've confirmed this repro (comment 5) doesn't reproduce the issue on Linux with cairo-1.17.2.tar.xz and pixman-0.36.0.tar.gz. Hmm, seems a Windows specific issue.

Fujii Hironori

Comment 7 2019-03-18 03:24:29 PDT

I tested the repro with the latest vcpkg. cairo 1.16.0 + pixman 0.38.0 (x86-windows): OK cairo 1.17.2 + pixman 0.38.0 (x86-windows): NG

Fujii Hironori

Comment 8 2019-03-18 18:24:12 PDT

I had a mistake in comment#6. I redid the experiment on Linux. I've confirmed this issue can be reproduced on Linux with cairo-1.17.2.tar.xz.

Fujii Hironori

Comment 9 2019-03-18 18:53:20 PDT

The upstream Cairo master branch has fixed this issue. This is the commit. https://gitlab.freedesktop.org/cairo/cairo/commit/2d1a137f3d27b60538c58b25e867288c7b0b61bc

Fujii Hironori

Comment 10 2019-03-28 18:49:15 PDT

https://github.com/WebKitForWindows/WinCairoRequirements/releases/tag/v2019.03.28 > Downgrades cairo to a previous version due to instability of the developer snapshot. Fixed.

Note You need to log in before you can comment on or make changes to this bug.