Summary: | [Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||
Component: | New Bugs | Assignee: | Justin Fan <justin_fan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, mmaxfield, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Justin Fan
2019-03-14 16:40:31 PDT
Created attachment 364720 [details]
Patch
Comment on attachment 364720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364720&action=review > Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp:49 > + promise.resolve(device.releaseNonNull()); Are you sure that releaseNonNull is the right thing here? Comment on attachment 364720 [details] Patch Clearing flags on attachment: 364720 Committed r243090: <https://trac.webkit.org/changeset/243090> All reviewed patches have been landed. Closing bug. |