Bug 195781

Summary: [Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Justin Fan 2019-03-14 16:40:31 PDT
[Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice
Comment 1 Justin Fan 2019-03-14 16:56:26 PDT
Created attachment 364720 [details]
Patch
Comment 2 Myles C. Maxfield 2019-03-14 17:00:38 PDT
Comment on attachment 364720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364720&action=review

> Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp:49
> +        promise.resolve(device.releaseNonNull());

Are you sure that releaseNonNull is the right thing here?
Comment 3 WebKit Commit Bot 2019-03-18 12:18:56 PDT
Comment on attachment 364720 [details]
Patch

Clearing flags on attachment: 364720

Committed r243090: <https://trac.webkit.org/changeset/243090>
Comment 4 WebKit Commit Bot 2019-03-18 12:18:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-18 12:19:17 PDT
<rdar://problem/48988528>