Bug 195781

Summary: [Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Justin Fan
Reported 2019-03-14 16:40:31 PDT
[Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice
Attachments
Patch (11.61 KB, patch)
2019-03-14 16:56 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-03-14 16:56:26 PDT
Created attachment 364720 [details] Patch
Myles C. Maxfield
Comment 2 2019-03-14 17:00:38 PDT
Comment on attachment 364720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364720&action=review > Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp:49 > + promise.resolve(device.releaseNonNull()); Are you sure that releaseNonNull is the right thing here?
WebKit Commit Bot
Comment 3 2019-03-18 12:18:56 PDT
Comment on attachment 364720 [details] Patch Clearing flags on attachment: 364720 Committed r243090: <https://trac.webkit.org/changeset/243090>
WebKit Commit Bot
Comment 4 2019-03-18 12:18:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-03-18 12:19:17 PDT
<rdar://problem/48988528>
Note You need to log in before you can comment on or make changes to this bug.