Bug 195780

Summary: Make it possible to test scrolling tree layer manipulation more easily
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fred.wang, koivisto, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 195733    
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Description Simon Fraser (smfr) 2019-03-14 16:13:19 PDT 
Make it possible to test scrolling tree layer manipulation more easily
Comment 1 Simon Fraser (smfr) 2019-03-14 16:16:57 PDT 
Created attachment 364711 [details]
Patch
Comment 2 Tim Horton 2019-03-14 16:25:28 PDT 
Comment on attachment 364711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364711&action=review

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h:64
> +@property (nonatomic, setter=_setScrollingUpdatesDisabledForTesting:) BOOL _scrollingUpdatesDisabledForTesting;

Shouldn't need this?

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:51
> +    BOOL m_scrollingUpdatesDisabled;

No m_ for ObjC ivars
Comment 3 Tim Horton 2019-03-14 16:25:52 PDT 
Comment on attachment 364711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364711&action=review

>> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:51
>> +    BOOL m_scrollingUpdatesDisabled;
> 
> No m_ for ObjC ivars

to be clear, you keep the _
Comment 4 Simon Fraser (smfr) 2019-03-14 16:33:27 PDT 
Created attachment 364716 [details]
Patch
Comment 5 WebKit Commit Bot 2019-03-14 18:10:15 PDT 
Comment on attachment 364716 [details]
Patch

Clearing flags on attachment: 364716

Committed r242979: <https://trac.webkit.org/changeset/242979>
Comment 6 Radar WebKit Bug Importer 2019-03-14 18:52:19 PDT 
<rdar://problem/48912027>