Bug 19577

Summary: JSCore does not compile in C++ environments where C99 headers are not present
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Fix compilation in C++ environments where C99 headers are not present darin: review+

Simon Hausmann
Reported 2008-06-16 06:34:24 PDT
Some JSCore public header files include stdbool.h. The stdbool.h header is a C99 feature, defining the "_Bool" type as well as the "true" and "false" constants. But it's completely unnecessary in C++ as the language already defines the "bool" type and its two values.
Attachments
Fix compilation in C++ environments where C99 headers are not present (2.52 KB, patch)
2008-06-16 06:35 PDT, Simon Hausmann 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2008-06-16 06:35:30 PDT
Created attachment 21725 [details] Fix compilation in C++ environments where C99 headers are not present Proposed patch from Thiago Macieira <tjmaciei@trolltech.com>
Simon Hausmann
Comment 2 2008-06-16 06:39:45 PDT
I think the patch is fine, but since this touches the header files of the public API I'd be great to get a review from someone with experience on handling those :)
Darin Adler
Comment 3 2008-06-16 08:53:35 PDT
Comment on attachment 21725 [details] Fix compilation in C++ environments where C99 headers are not present Seems OK. r=me
Simon Hausmann
Comment 4 2008-06-16 14:23:37 PDT
Landed in r34606
Note You need to log in before you can comment on or make changes to this bug.