Bug 195740

Summary: [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, lforschler, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Fujii Hironori
Reported 2019-03-14 03:17:25 PDT
[Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
Attachments
Patch (14.90 KB, patch)
2019-03-14 03:31 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.87 KB, patch)
2019-03-14 18:53 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-03-14 03:31:48 PDT
Created attachment 364652 [details] Patch
Ross Kirsling
Comment 2 2019-03-14 11:27:39 PDT
Comment on attachment 364652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364652&action=review Seems fine overall from my perspective. > Tools/MiniBrowser/win/MainWindow.h:36 > + using BrowserWindowFactory = std::function<Ref<BrowserWindow>(HWND mainWnd, HWND urlBarWnd, bool usesLayeredWebView, bool pageLoadTesting)>; Shouldn't this be WTF::Function? > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:304 > + auto& thisWindow = toWebKitBrowserWindow(clientInfo); Doesn't look like you're using this one.
Fujii Hironori
Comment 3 2019-03-14 18:39:37 PDT
Comment on attachment 364652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364652&action=review >> Tools/MiniBrowser/win/MainWindow.h:36 >> + using BrowserWindowFactory = std::function<Ref<BrowserWindow>(HWND mainWnd, HWND urlBarWnd, bool usesLayeredWebView, bool pageLoadTesting)>; > > Shouldn't this be WTF::Function? I prefer std::function to WTF::Function in MiniBrowser for the same reason I prefer std::vector to WTF::Vector. Bug 189846 Comment 12 Bug 191101 Comment 3 >> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:304 >> + auto& thisWindow = toWebKitBrowserWindow(clientInfo); > > Doesn't look like you're using this one. Will fix.
Fujii Hironori
Comment 4 2019-03-14 18:53:17 PDT
Created attachment 364750 [details] Patch for landing
Fujii Hironori
Comment 5 2019-03-14 19:16:13 PDT
Committed r242984: <https://trac.webkit.org/changeset/242984>
Radar WebKit Bug Importer
Comment 6 2019-03-14 19:17:22 PDT
<rdar://problem/48912595>
Note You need to log in before you can comment on or make changes to this bug.