Bug 195731

Summary: Device orientation's permission should only require a user gesture to prompt the user
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 195750    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2019-03-13 19:49:17 PDT 
Device orientation's permission should only require a user gesture to prompt the user. If the user already made a decision, we should resolve the promise with this decision, even without user gesture.
This is useful for JS to figure out if they are access to device orientation or not because showing UI for the user to give permission.
Comment 1 Chris Dumez 2019-03-13 19:51:19 PDT 
Created attachment 364612 [details]
Patch
Comment 2 Chris Dumez 2019-03-14 11:47:08 PDT 
Comment on attachment 364612 [details]
Patch

ping review? This is blocking my next patch.
Comment 3 Geoffrey Garen 2019-03-14 11:55:41 PDT 
Comment on attachment 364612 [details]
Patch

r=me
Comment 4 Chris Dumez 2019-03-14 11:58:03 PDT 
Comment on attachment 364612 [details]
Patch

Clearing flags on attachment: 364612

Committed r242951: <https://trac.webkit.org/changeset/242951>
Comment 5 Chris Dumez 2019-03-14 11:58:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-14 11:59:19 PDT 
<rdar://problem/48895657>