| Summary: | Long press gesture recognizers in WKWebView are conflicting with internal gesture recognizers | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Magahern <jmagahern> | ||||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bdakin, commit-queue, ews-watchlist, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
James Magahern
2019-03-13 19:19:01 PDT
Created attachment 364609 [details]
Patch
Attachment 364609 [details] did not pass style-queue:
ERROR: Source/WebKit/ChangeLog:5: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebKit/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebKit/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Total errors found: 3 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364609&action=review You will need to repost a patch with the spaces changes since you do not have committed status on WebKit, but other wise this looks good. > w/Source/WebKit/ChangeLog:10 > + canPreventGestureRecognizer whitelist. Spaces, not tabs, even in change logs. Comment on attachment 364609 [details] Patch Attachment 364609 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11500552 New failing tests: storage/indexeddb/modern/gc-closes-database-private.html Created attachment 364632 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 365628 [details]
Patch
I went ahead and moved all this stuff to WebKitAdditions instead. Created attachment 365645 [details]
Patch
Created attachment 365646 [details]
Patch
Comment on attachment 365646 [details] Patch Clearing flags on attachment: 365646 Committed r243351: <https://trac.webkit.org/changeset/243351> All reviewed patches have been landed. Closing bug. |