Bug 195724

Summary: [ContentChangeObserver] Stop content observation when content calls preventDefault() on touch events
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2019-03-13 18:54:15 PDT
ssia
Comment 1 Radar WebKit Bug Importer 2019-03-13 18:54:45 PDT
<rdar://problem/48873456>
Comment 2 zalan 2019-03-13 18:59:38 PDT
Created attachment 364606 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-03-13 19:02:49 PDT
Comment on attachment 364606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364606&action=review

> Source/WebCore/ChangeLog:9
> +        Call willNotProceedWithClick on preventDefault. This is very similar to the long press case.

Testable?
Comment 4 zalan 2019-03-13 21:23:39 PDT
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 364606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364606&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Call willNotProceedWithClick on preventDefault. This is very similar to the long press case.
> 
> Testable?
Unfortunately not (This is about stop observing)
Comment 5 WebKit Commit Bot 2019-03-13 21:49:21 PDT
Comment on attachment 364606 [details]
Patch

Clearing flags on attachment: 364606

Committed r242935: <https://trac.webkit.org/changeset/242935>
Comment 6 WebKit Commit Bot 2019-03-13 21:49:23 PDT
All reviewed patches have been landed.  Closing bug.