Bug 195724 - [ContentChangeObserver] Stop content observation when content calls preventDefault() on touch events
Summary: [ContentChangeObserver] Stop content observation when content calls preventDe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-13 18:54 PDT by zalan
Modified: 2019-03-13 21:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.94 KB, patch)
2019-03-13 18:59 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-13 18:54:15 PDT 
ssia
Comment 1 Radar WebKit Bug Importer 2019-03-13 18:54:45 PDT 
<rdar://problem/48873456>
Comment 2 zalan 2019-03-13 18:59:38 PDT 
Created attachment 364606 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-03-13 19:02:49 PDT 
Comment on attachment 364606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364606&action=review

> Source/WebCore/ChangeLog:9
> +        Call willNotProceedWithClick on preventDefault. This is very similar to the long press case.

Testable?
Comment 4 zalan 2019-03-13 21:23:39 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 364606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364606&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Call willNotProceedWithClick on preventDefault. This is very similar to the long press case.
> 
> Testable?
Unfortunately not (This is about stop observing)
Comment 5 WebKit Commit Bot 2019-03-13 21:49:21 PDT 
Comment on attachment 364606 [details]
Patch

Clearing flags on attachment: 364606

Committed r242935: <https://trac.webkit.org/changeset/242935>
Comment 6 WebKit Commit Bot 2019-03-13 21:49:23 PDT 
All reviewed patches have been landed.  Closing bug.