Bug 195718

Summary: _WKDownload should conform to NSCopying protocol
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Alex Christensen 2019-03-13 17:35:47 PDT
_WKDownload should conform to NSCopying protocol
Comment 1 Alex Christensen 2019-03-13 17:36:45 PDT
Created attachment 364596 [details]
Patch
Comment 2 Tim Horton 2019-03-15 15:13:24 PDT
Comment on attachment 364596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364596&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm:88
> +    return [self retain];

copy -> cancel -> cancels the original, I guess that's OK?
Comment 3 Alex Christensen 2019-03-15 15:18:36 PDT
http://trac.webkit.org/r243016
Comment 4 Radar WebKit Bug Importer 2019-03-15 15:19:17 PDT
<rdar://problem/48940660>