Bug 195703

Summary:

Remove some unnecessary !USE(UIKIT_KEYBOARD_ADDITIONS) guards

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2019-03-13 14:45:02 PDT

Following the fix for bug #193452 we now make use of windowsKeyCodeForCharCode() even for hardware key events when USE(UIKIT_KEYBOARD_ADDITIONS) is enabled. Update a comment and remove some unnecessary USE(UIKIT_KEYBOARD_ADDITIONS) guards.

Attachments
Patch (3.91 KB, patch) 2019-03-13 14:48 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2019-03-13 14:48:48 PDT

Created attachment 364577 [details] Patch

Daniel Bates

Comment 2 2019-03-13 14:51:07 PDT

No behavior change despite the removing of the guards even when building with USE(UIKIT_KEYBOARD_ADDITIONS) enabled because though windowsKeyCodeForCharCode() returned 0 (because the char is not known) we fall back to using the event's key code, which worked out for those char that we're only recognized when building with !USE(UIKIT_KEYBOARD_ADDITIONS).

Daniel Bates

Comment 3 2019-03-13 15:26:12 PDT

Comment on attachment 364577 [details] Patch Clearing flags on attachment: 364577 Committed r242915: <https://trac.webkit.org/changeset/242915>

Daniel Bates

Comment 4 2019-03-13 15:26:13 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-03-13 15:27:14 PDT

<rdar://problem/48866045>

Note You need to log in before you can comment on or make changes to this bug.