Following the fix for bug #193452 we now make use of windowsKeyCodeForCharCode() even for hardware key events when USE(UIKIT_KEYBOARD_ADDITIONS) is enabled. Update a comment and remove some unnecessary USE(UIKIT_KEYBOARD_ADDITIONS) guards.
Created attachment 364577 [details] Patch
No behavior change despite the removing of the guards even when building with USE(UIKIT_KEYBOARD_ADDITIONS) enabled because though windowsKeyCodeForCharCode() returned 0 (because the char is not known) we fall back to using the event's key code, which worked out for those char that we're only recognized when building with !USE(UIKIT_KEYBOARD_ADDITIONS).
Comment on attachment 364577 [details] Patch Clearing flags on attachment: 364577 Committed r242915: <https://trac.webkit.org/changeset/242915>
All reviewed patches have been landed. Closing bug.
<rdar://problem/48866045>