Bug 195703 - Remove some unnecessary !USE(UIKIT_KEYBOARD_ADDITIONS) guards
Summary: Remove some unnecessary !USE(UIKIT_KEYBOARD_ADDITIONS) guards
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2019-03-13 14:45 PDT by Daniel Bates
Modified: 2019-03-13 15:27 PDT (History)
3 users (show)

See Also:

Patch (3.91 KB, patch)
2019-03-13 14:48 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-03-13 14:45:02 PDT
Following the fix for bug #193452 we now make use of windowsKeyCodeForCharCode() even for hardware key events when USE(UIKIT_KEYBOARD_ADDITIONS) is enabled. Update a comment and remove some unnecessary USE(UIKIT_KEYBOARD_ADDITIONS) guards.
Comment 1 Daniel Bates 2019-03-13 14:48:48 PDT
Created attachment 364577 [details]
Comment 2 Daniel Bates 2019-03-13 14:51:07 PDT
No behavior change despite the removing of the guards even when building with USE(UIKIT_KEYBOARD_ADDITIONS) enabled because though windowsKeyCodeForCharCode() returned 0 (because the char is not known) we fall back to using the event's key code, which worked out for those char that we're only recognized when building with !USE(UIKIT_KEYBOARD_ADDITIONS).
Comment 3 Daniel Bates 2019-03-13 15:26:12 PDT
Comment on attachment 364577 [details]

Clearing flags on attachment: 364577

Committed r242915: <https://trac.webkit.org/changeset/242915>
Comment 4 Daniel Bates 2019-03-13 15:26:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-13 15:27:14 PDT