| Summary: | Web Inspector: Console: add a setting for controlling auto-expansion of Trace messages | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Devin Rousso
2019-03-13 11:59:40 PDT
Created attachment 364558 [details]
Patch
Comment on attachment 364558 [details]
Patch
Hmm, I'm not sure this deserves a setting. Do we have a good reason for it (other then our Inspector protocol traffic logging?)
(In reply to Joseph Pecoraro from comment #3) > Comment on attachment 364558 [details] > Patch > > Hmm, I'm not sure this deserves a setting. Do we have a good reason for it > (other then our Inspector protocol traffic logging?) I don't have a "good" reason, but I have run into situations before where when running `console.trace(a, b)` a LOT of times, I'll only really care about ones with a particular value for `a` or `b`, and having to scroll/filter is a bit annoying. This solves the issue quite nicely :) I would also prefer it to not be expanded by default. Rather than making that choice for everyone, a setting lets each person choose for themself. I could see this being useful. Would be good to know how often many of these settings get used in the wild, so we can cull the unused ones or ones always enabled. Comment on attachment 364558 [details] Patch Clearing flags on attachment: 364558 Committed r243220: <https://trac.webkit.org/changeset/243220> All reviewed patches have been landed. Closing bug. |