Bug 195684 – REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate.

[Chris Dumez]

<rdar://problem/48294714>

[Chris Dumez]

Created attachment 364560 [details]
Patch

[Antti Koivisto]

Comment on attachment 364560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364560&action=review

> Source/WebCore/ChangeLog:12
> +        When a navigation is triggered by JS (and not the client), we create the Navigation object in

Cmd-left/right arrow involves JS?

> Source/WebCore/ChangeLog:22
> +        This is a lot error prone, the WebProcess knows more accurately which history items it is going

"a lot error prone"

[Chris Dumez]

Comment on attachment 364560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364560&action=review

>> Source/WebCore/ChangeLog:12
>> +        When a navigation is triggered by JS (and not the client), we create the Navigation object in
> 
> Cmd-left/right arrow involves JS?

Not JS but it is a navigation triggered by the WebProcess as opposed by the UIProcess. It seems to be the same code path as navigating via JS.

[Chris Dumez]

Created attachment 364565 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 364565 [details]
Patch

Clearing flags on attachment: 364565

Committed r242903: <https://trac.webkit.org/changeset/242903>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alex Christensen]

Comment on attachment 364565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364565&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:4522
> +                WTFLogAlways("WebPageProxy::decidePolicyForNavigationAction() creates back/forward navigation from item %s", fromItem ? fromItem->url().utf8().data() : "null");

Did you mean to commit this?  We probably shouldn't be logging URLs without at least checking ephemerality of the WebsiteDataStore.

[Chris Dumez]

(In reply to Alex Christensen from comment #8)
> Comment on attachment 364565 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364565&action=review
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:4522
> > +                WTFLogAlways("WebPageProxy::decidePolicyForNavigationAction() creates back/forward navigation from item %s", fromItem ? fromItem->url().utf8().data() : "null");
> 
> Did you mean to commit this?  We probably shouldn't be logging URLs without
> at least checking ephemerality of the WebsiteDataStore.

Definitely not, this was for me debugging.

[Chris Dumez]

(In reply to Chris Dumez from comment #9)
> (In reply to Alex Christensen from comment #8)
> > Comment on attachment 364565 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=364565&action=review
> > 
> > > Source/WebKit/UIProcess/WebPageProxy.cpp:4522
> > > +                WTFLogAlways("WebPageProxy::decidePolicyForNavigationAction() creates back/forward navigation from item %s", fromItem ? fromItem->url().utf8().data() : "null");
> > 
> > Did you mean to commit this?  We probably shouldn't be logging URLs without
> > at least checking ephemerality of the WebsiteDataStore.
> 
> Definitely not, this was for me debugging.

Dropped in <https://trac.webkit.org/changeset/243733>.