Bug 195680

Summary: [ews-app] Generate status-bubble hover-over messages
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dewei_zhu, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch none

Aakash Jain
Reported 2019-03-13 08:49:50 PDT
Hovering over status bubbles should display appropriate build details.
Attachments
Proposed patch (7.76 KB, patch)
2019-03-13 09:18 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Proposed patch (7.80 KB, patch)
2019-03-13 11:51 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-13 09:18:50 PDT
Created attachment 364540 [details] Proposed patch Tested on a local instance. Also replaced double-quotes(") with single-quotes('). This patch would apply to ToT after https://bugs.webkit.org/show_bug.cgi?id=195668
Jonathan Bedard
Comment 2 2019-03-13 09:29:20 PDT
Comment on attachment 364540 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364540&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:67 > + bubble['state'] = 'pass' Is this correct? When we have warnings, we mark it as pass? If so, why not combine with the SUCCESS state?
Jonathan Bedard
Comment 3 2019-03-13 09:39:02 PDT
Comment on attachment 364540 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364540&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:68 > + bubble['details_message'] = 'Pass\n\n' + self._iso_time(build.complete_at) Maybe this should say 'Warning\n\n' instead of 'Pass\n\n', that way we're at least surfacing the error in some way.
Aakash Jain
Comment 4 2019-03-13 09:47:47 PDT
Comment on attachment 364540 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364540&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:67 >> + bubble['state'] = 'pass' > > Is this correct? When we have warnings, we mark it as pass? If so, why not combine with the SUCCESS state? Yeah, because mostly build should finish with warning state in case of a minor issue. Any major issue with patch will fail the build. >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:68 >> + bubble['details_message'] = 'Pass\n\n' + self._iso_time(build.complete_at) > > Maybe this should say 'Warning\n\n' instead of 'Pass\n\n', that way we're at least surfacing the error in some way. Agree. will update it.
Aakash Jain
Comment 5 2019-03-13 11:51:08 PDT
Created attachment 364556 [details] Proposed patch > Maybe this should say 'Warning\n\n' instead of 'Pass\n\n', that way we're at least surfacing the error in some way. Done.
WebKit Commit Bot
Comment 6 2019-03-14 15:06:22 PDT
Comment on attachment 364556 [details] Proposed patch Clearing flags on attachment: 364556 Committed r242967: <https://trac.webkit.org/changeset/242967>
WebKit Commit Bot
Comment 7 2019-03-14 15:06:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-14 15:07:21 PDT
<rdar://problem/48903534>
Note You need to log in before you can comment on or make changes to this bug.