Bug 195668

Summary: [ews-app] Use Buildbot result code variables
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dewei_zhu, jbedard, kocsen_chung, lforschler, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2019-03-13 04:24:53 PDT
Buildbot result codes are integers (e.g.: 0 for SUCCESS, 1 for WARNINGS etc.). Instead of referring these integers in ews-app code, we should save these values in corresponding variables and refer them by name. It would make the code more readable. These result codes are defined in https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/results.py
Attachments
Proposed patch (3.80 KB, patch)
2019-03-13 04:43 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-13 04:43:57 PDT
Created attachment 364521 [details] Proposed patch
Jonathan Bedard
Comment 2 2019-03-13 09:26:47 PDT
Unofficial r=me.
WebKit Commit Bot
Comment 3 2019-03-13 10:03:48 PDT
Comment on attachment 364521 [details] Proposed patch Clearing flags on attachment: 364521 Committed r242884: <https://trac.webkit.org/changeset/242884>
WebKit Commit Bot
Comment 4 2019-03-13 10:03:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-03-13 10:04:20 PDT
<rdar://problem/48851133>
Note You need to log in before you can comment on or make changes to this bug.