Summary: | In CachedFrame's constructor, release-assert that DOMWindow still has a frame after page-caching subframes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, ews-watchlist, ggaren, koivisto, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2019-03-12 00:05:41 PDT
Created attachment 364362 [details]
Adds a release assert
Comment on attachment 364362 [details] Adds a release assert Attachment 364362 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11470551 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall.https.html Created attachment 364372 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 364372 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
Unrelated.
Comment on attachment 364362 [details] Adds a release assert Clearing flags on attachment: 364362 Committed r242797: <https://trac.webkit.org/changeset/242797> All reviewed patches have been landed. Closing bug. Comment on attachment 364362 [details] Adds a release assert View in context: https://bugs.webkit.org/attachment.cgi?id=364362&action=review > Source/WebCore/history/CachedFrame.cpp:150 > + RELEASE_ASSERT(m_document->domWindow()->frame()); Getting hit (rdar://problem/49877867). |