Bug 195587

Summary:

Web Inspector: Database: lazily create the agent

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

195971

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews107 for mac-highsierra-wk2	none
Archive of layout-test-results from ews112 for mac-highsierra	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none

Devin Rousso

Reported 2019-03-11 17:50:30 PDT

Attachments
Patch (33.55 KB, patch) 2019-03-17 14:34 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (2.46 MB, application/zip) 2019-03-17 15:38 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.67 MB, application/zip) 2019-03-17 15:50 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-highsierra (2.30 MB, application/zip) 2019-03-17 16:21 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.56 MB, application/zip) 2019-03-17 16:36 PDT, EWS Watchlist	no flags	Details
Patch (39.24 KB, patch) 2019-03-17 16:59 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (37.95 KB, patch) 2019-03-19 15:53 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (38.11 KB, patch) 2019-03-19 17:30 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (38.18 KB, patch) 2019-03-19 17:41 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (3.22 MB, application/zip) 2019-03-19 22:44 PDT, EWS Watchlist	no flags	Details
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-11 17:54:11 PDT

<rdar://problem/48791735>

Devin Rousso

Comment 2 2019-03-17 14:34:49 PDT

Created attachment 364975 [details] Patch Looks like we never had inspector tests for `DatabaseAgent` or `WI.databaseManager` :(\nI'll need to add some.

EWS Watchlist

Comment 3 2019-03-17 15:38:30 PDT Comment hidden (obsolete)

Comment on attachment 364975 [details] Patch Attachment 364975 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11543751 New failing tests: inspector/protocol/backend-dispatcher-argument-errors.html inspector/runtime/CommandLineAPI-inspect.html

EWS Watchlist

Comment 4 2019-03-17 15:38:32 PDT Comment hidden (obsolete)

Created attachment 364977 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-03-17 15:50:20 PDT Comment hidden (obsolete)

Comment on attachment 364975 [details] Patch Attachment 364975 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11543773 New failing tests: inspector/protocol/backend-dispatcher-argument-errors.html inspector/runtime/CommandLineAPI-inspect.html

EWS Watchlist

Comment 6 2019-03-17 15:50:22 PDT Comment hidden (obsolete)

Created attachment 364978 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-03-17 16:21:57 PDT Comment hidden (obsolete)

Comment on attachment 364975 [details] Patch Attachment 364975 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11543815 New failing tests: inspector/protocol/backend-dispatcher-argument-errors.html inspector/runtime/CommandLineAPI-inspect.html

EWS Watchlist

Comment 8 2019-03-17 16:21:59 PDT Comment hidden (obsolete)

Created attachment 364980 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2019-03-17 16:36:42 PDT Comment hidden (obsolete)

Comment on attachment 364975 [details] Patch Attachment 364975 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11543834 New failing tests: storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html

EWS Watchlist

Comment 10 2019-03-17 16:36:44 PDT Comment hidden (obsolete)

Created attachment 364984 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Devin Rousso

Comment 11 2019-03-17 16:59:53 PDT

Created attachment 364986 [details] Patch

Devin Rousso

Comment 12 2019-03-19 15:53:19 PDT

Created attachment 365250 [details] Patch

Devin Rousso

Comment 13 2019-03-19 17:30:03 PDT

Created attachment 365270 [details] Patch

Devin Rousso

Comment 14 2019-03-19 17:41:21 PDT

Created attachment 365272 [details] Patch

EWS Watchlist

Comment 15 2019-03-19 22:44:03 PDT Comment hidden (obsolete)

Comment on attachment 365272 [details] Patch Attachment 365272 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11575469 New failing tests: storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html

EWS Watchlist

Comment 16 2019-03-19 22:44:05 PDT Comment hidden (obsolete)

Created attachment 365317 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

WebKit Commit Bot

Comment 17 2019-03-20 11:53:54 PDT

Comment on attachment 365272 [details] Patch Clearing flags on attachment: 365272 Committed r243219: <https://trac.webkit.org/changeset/243219>

WebKit Commit Bot

Comment 18 2019-03-20 11:53:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.