Bug 19557

Summary:

(JavaScriptCore) minidom uses C++ style comments

Product:

WebKit

Reporter:

Christian Dywan <christian>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Use only C style comments in minidom	none

Christian Dywan

Reported 2008-06-15 08:49:41 PDT

The JavaScriptCore test program minidom is written in C. However it makes use of C++ style "//" comments, including wtf headers used in minidom. That means only compilers supporting that part of C99 or particularly support for C++ style comments can build minidom.

Attachments
Use only C style comments in minidom (10.12 KB, patch) 2008-06-15 08:53 PDT, Christian Dywan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Christian Dywan

Comment 1 2008-06-15 08:53:46 PDT

Created attachment 21713 [details] Use only C style comments in minidom This patch fixes the comments in minidom and C headers from wtf used by minidom. It was tested with gcc in c89 mode.

Sam Weinig

Comment 2 2008-06-15 10:26:37 PDT

Comment on attachment 21713 [details] Use only C style comments in minidom This needs a ChangeLog.

Christian Dywan

Comment 3 2008-06-16 06:42:10 PDT

Comment on attachment 21713 [details] Use only C style comments in minidom Committed in revision 34598.

Note You need to log in before you can comment on or make changes to this bug.