Summary: | JavaScriptCore headers use C++ style comments | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Christian Dywan <christian> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Christian Dywan
2008-06-15 06:01:07 PDT
Created attachment 21710 [details]
Use only C style comments in public API headers
This patch replaces C++ style comments with C style comments in files that are relevant to public C API, which is JavaScript.h and all headers it includes.
Created attachment 21712 [details]
Use only C style comments, including CF and BSTR headers
Updated patch, including CF and BSTR headers. Also the "mode" lines should now say "c" instead of "c++" where appropriate.
Comment on attachment 21712 [details]
Use only C style comments, including CF and BSTR headers
This needs a ChangeLog.
I don't think it's good for public header to have mode lines. > I don't think it's good for public header to have mode lines.
I tend to agree here yet left them here because virtually all source files have them at the moment.
I will not commit for a few hours to see if there are others who would agree with removing the mode files entirely. Opinions welcome.
Yes, please remove the mode lines. Comment on attachment 21712 [details]
Use only C style comments, including CF and BSTR headers
Committed in revision 34599. All mode lines were removed entierly.
|