Bug 19552

Summary:

JavaScriptCore headers use C++ style comments

Product:

WebKit

Reporter:

Christian Dywan <christian>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Use only C style comments in public API headers	none
Use only C style comments, including CF and BSTR headers	none

Christian Dywan

Reported 2008-06-15 06:01:07 PDT

The JavaScriptCore API is basically usable from C. However the public headers make use of C++ style "//" comments. That means only compilers supporting that part of C99 or particularly support for C++ style comments can parse these headers.

Attachments
Use only C style comments in public API headers (4.98 KB, patch) 2008-06-15 06:03 PDT, Christian Dywan	no flags	Details Formatted Diff Diff
Use only C style comments, including CF and BSTR headers (7.29 KB, patch) 2008-06-15 08:00 PDT, Christian Dywan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Christian Dywan

Comment 1 2008-06-15 06:03:31 PDT

Created attachment 21710 [details] Use only C style comments in public API headers This patch replaces C++ style comments with C style comments in files that are relevant to public C API, which is JavaScript.h and all headers it includes.

Christian Dywan

Comment 2 2008-06-15 08:00:48 PDT

Created attachment 21712 [details] Use only C style comments, including CF and BSTR headers Updated patch, including CF and BSTR headers. Also the "mode" lines should now say "c" instead of "c++" where appropriate.

Sam Weinig

Comment 3 2008-06-15 10:24:59 PDT

Comment on attachment 21712 [details] Use only C style comments, including CF and BSTR headers This needs a ChangeLog.

Darin Adler

Comment 4 2008-06-15 10:41:41 PDT

I don't think it's good for public header to have mode lines.

Christian Dywan

Comment 5 2008-06-15 12:01:35 PDT

> I don't think it's good for public header to have mode lines. I tend to agree here yet left them here because virtually all source files have them at the moment. I will not commit for a few hours to see if there are others who would agree with removing the mode files entirely. Opinions welcome.

Alexey Proskuryakov

Comment 6 2008-06-15 17:17:00 PDT

Yes, please remove the mode lines.

Christian Dywan

Comment 7 2008-06-16 06:52:46 PDT

Comment on attachment 21712 [details] Use only C style comments, including CF and BSTR headers Committed in revision 34599. All mode lines were removed entierly.

Note You need to log in before you can comment on or make changes to this bug.