Bug 195515

Summary: REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty"
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Nikita Vasilyev
Reported 2019-03-08 23:45:34 PST
This has no user impact. An assert triggers on every overridden property when Show Jump to Effective Property Button is disabled.
Attachments
Patch (1.90 KB, patch)
2019-03-08 23:49 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-08 23:45:49 PST
<rdar://problem/48737315>
Nikita Vasilyev
Comment 2 2019-03-08 23:49:32 PST
Created attachment 364119 [details] Patch
Matt Baker
Comment 3 2019-03-11 12:46:09 PDT
Comment on attachment 364119 [details] Patch rs=me. Maybe we should adopt a new pattern in the constructor of classes taking an optional delegate: constructor(delegate) { - this._delegate = delegate || null; + this._delegate = delegate || {}; } Then we could simplify tests throughout the class: - if (this._delegate && this._delegate.someMethod) { ... } + if (this._delegate.someMethod) { ... }
WebKit Commit Bot
Comment 4 2019-03-11 13:05:12 PDT
Comment on attachment 364119 [details] Patch Clearing flags on attachment: 364119 Committed r242731: <https://trac.webkit.org/changeset/242731>
WebKit Commit Bot
Comment 5 2019-03-11 13:05:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.