Summary: | REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty" | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Nikita Vasilyev
2019-03-08 23:45:34 PST
Created attachment 364119 [details]
Patch
Comment on attachment 364119 [details]
Patch
rs=me. Maybe we should adopt a new pattern in the constructor of classes taking an optional delegate:
constructor(delegate)
{
- this._delegate = delegate || null;
+ this._delegate = delegate || {};
}
Then we could simplify tests throughout the class:
- if (this._delegate && this._delegate.someMethod) { ... }
+ if (this._delegate.someMethod) { ... }
Comment on attachment 364119 [details] Patch Clearing flags on attachment: 364119 Committed r242731: <https://trac.webkit.org/changeset/242731> All reviewed patches have been landed. Closing bug. |