Bug 195515

Summary:

REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty"

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Nikita Vasilyev 2019-03-08 23:45:34 PST

This has no user impact.

An assert triggers on every overridden property when Show Jump to Effective Property Button is disabled.

Comment 1 Radar WebKit Bug Importer 2019-03-08 23:45:49 PST

<rdar://problem/48737315>

Comment 2 Nikita Vasilyev 2019-03-08 23:49:32 PST

Created attachment 364119 [details]
Patch

Comment 3 Matt Baker 2019-03-11 12:46:09 PDT

Comment on attachment 364119 [details]
Patch

rs=me. Maybe we should adopt a new pattern in the constructor of classes taking an optional delegate:

constructor(delegate)
{
-    this._delegate = delegate || null;
+    this._delegate = delegate || {};
}

Then we could simplify tests throughout the class:

- if (this._delegate && this._delegate.someMethod) { ... }
+ if (this._delegate.someMethod) { ... }

Comment 4 WebKit Commit Bot 2019-03-11 13:05:12 PDT

Comment on attachment 364119 [details]
Patch

Clearing flags on attachment: 364119

Committed r242731: <https://trac.webkit.org/changeset/242731>

Comment 5 WebKit Commit Bot 2019-03-11 13:05:14 PDT

All reviewed patches have been landed.  Closing bug.