Bug 195478

Summary: [ContentChangeObserver] Expand "isConsideredClickable" to descendants
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2019-03-08 14:06:28 PST
In case when the visible content already had renderers it's not sufficient to check the "newly visible" element only since it might just be the container for the clickable content.
Attachments
Patch (9.13 KB, patch)
2019-03-08 14:31 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (9.37 KB, patch)
2019-03-08 14:34 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (9.43 KB, patch)
2019-03-08 14:57 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-08 14:06:54 PST
<rdar://problem/48724935>
zalan
Comment 2 2019-03-08 14:31:57 PST
Created attachment 364068 [details] Patch
zalan
Comment 3 2019-03-08 14:34:24 PST
Created attachment 364069 [details] Patch
Simon Fraser (smfr)
Comment 4 2019-03-08 14:48:24 PST
Comment on attachment 364069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364069&action=review > Source/WebCore/ChangeLog:9 > + In StyleChangeScope we try to figure out whether a newly visible content should stick (menu panes etc) by checking if it is clickable. "newly visible content"? > Source/WebCore/page/ios/ContentChangeObserver.cpp:310 > + if (!m_wasHidden || isConsideredHidden()) Would be clearer as if (changedFromHiddenToVisible())
zalan
Comment 5 2019-03-08 14:57:46 PST
Created attachment 364073 [details] Patch
WebKit Commit Bot
Comment 6 2019-03-08 15:51:11 PST
Comment on attachment 364073 [details] Patch Clearing flags on attachment: 364073 Committed r242661: <https://trac.webkit.org/changeset/242661>
WebKit Commit Bot
Comment 7 2019-03-08 15:51:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.