Bug 195478

Summary: [ContentChangeObserver] Expand "isConsideredClickable" to descendants
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2019-03-08 14:06:28 PST 
In case when the visible content already had renderers it's not sufficient to check the "newly visible" element only since it might just be the container for the clickable content.
Comment 1 Radar WebKit Bug Importer 2019-03-08 14:06:54 PST 
<rdar://problem/48724935>
Comment 2 zalan 2019-03-08 14:31:57 PST 
Created attachment 364068 [details]
Patch
Comment 3 zalan 2019-03-08 14:34:24 PST 
Created attachment 364069 [details]
Patch
Comment 4 Simon Fraser (smfr) 2019-03-08 14:48:24 PST 
Comment on attachment 364069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364069&action=review

> Source/WebCore/ChangeLog:9
> +        In StyleChangeScope we try to figure out whether a newly visible content should stick (menu panes etc) by checking if it is clickable.

"newly visible content"?

> Source/WebCore/page/ios/ContentChangeObserver.cpp:310
> +    if (!m_wasHidden || isConsideredHidden())

Would be clearer as if (changedFromHiddenToVisible())
Comment 5 zalan 2019-03-08 14:57:46 PST 
Created attachment 364073 [details]
Patch
Comment 6 WebKit Commit Bot 2019-03-08 15:51:11 PST 
Comment on attachment 364073 [details]
Patch

Clearing flags on attachment: 364073

Committed r242661: <https://trac.webkit.org/changeset/242661>
Comment 7 WebKit Commit Bot 2019-03-08 15:51:12 PST 
All reviewed patches have been landed.  Closing bug.