Summary: | Rename AssertionState::Download | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, commit-queue, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brady Eidson
2019-03-08 09:59:43 PST
Created attachment 364025 [details]
Patch
Comment on attachment 364025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364025&action=review > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:61 > - m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::Download); > + m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::UnboundedNetworking); "WebKit downloads" => "WebKit unbounded networking"? (In reply to Andy Estes from comment #2) > Comment on attachment 364025 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364025&action=review > > > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:61 > > - m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::Download); > > + m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::UnboundedNetworking); > > "WebKit downloads" => "WebKit unbounded networking"? In the case of the DownloadMap, we know it's "downloads" An UploadMap change coming very soon will name its "uploads" Comment on attachment 364025 [details] Patch Clearing flags on attachment: 364025 Committed r242646: <https://trac.webkit.org/changeset/242646> All reviewed patches have been landed. Closing bug. |