Bug 195465

Summary: Rename AssertionState::Download
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brady Eidson
Reported 2019-03-08 09:59:43 PST
Rename AssertionState::Download It's about Uploads also.
Attachments
Patch (4.04 KB, patch)
2019-03-08 10:12 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2019-03-08 10:12:12 PST
Created attachment 364025 [details] Patch
Andy Estes
Comment 2 2019-03-08 10:13:15 PST
Comment on attachment 364025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364025&action=review > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:61 > - m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::Download); > + m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::UnboundedNetworking); "WebKit downloads" => "WebKit unbounded networking"?
Brady Eidson
Comment 3 2019-03-08 10:14:12 PST
(In reply to Andy Estes from comment #2) > Comment on attachment 364025 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364025&action=review > > > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:61 > > - m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::Download); > > + m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::UnboundedNetworking); > > "WebKit downloads" => "WebKit unbounded networking"? In the case of the DownloadMap, we know it's "downloads" An UploadMap change coming very soon will name its "uploads"
WebKit Commit Bot
Comment 4 2019-03-08 11:01:37 PST
Comment on attachment 364025 [details] Patch Clearing flags on attachment: 364025 Committed r242646: <https://trac.webkit.org/changeset/242646>
WebKit Commit Bot
Comment 5 2019-03-08 11:01:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-08 11:04:38 PST
<rdar://problem/48718522>
Note You need to log in before you can comment on or make changes to this bug.