Bug 195465 - Rename AssertionState::Download
Summary: Rename AssertionState::Download
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-08 09:59 PST by Brady Eidson
Modified: 2019-03-08 11:04 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.04 KB, patch)
2019-03-08 10:12 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2019-03-08 09:59:43 PST
Rename AssertionState::Download

It's about Uploads also.
Comment 1 Brady Eidson 2019-03-08 10:12:12 PST
Created attachment 364025 [details]
Patch
Comment 2 Andy Estes 2019-03-08 10:13:15 PST
Comment on attachment 364025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364025&action=review

> Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:61
> -        m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::Download);
> +        m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::UnboundedNetworking);

"WebKit downloads" => "WebKit unbounded networking"?
Comment 3 Brady Eidson 2019-03-08 10:14:12 PST
(In reply to Andy Estes from comment #2)
> Comment on attachment 364025 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364025&action=review
> 
> > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:61
> > -        m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::Download);
> > +        m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::UnboundedNetworking);
> 
> "WebKit downloads" => "WebKit unbounded networking"?

In the case of the DownloadMap, we know it's "downloads"

An UploadMap change coming very soon will name its "uploads"
Comment 4 WebKit Commit Bot 2019-03-08 11:01:37 PST
Comment on attachment 364025 [details]
Patch

Clearing flags on attachment: 364025

Committed r242646: <https://trac.webkit.org/changeset/242646>
Comment 5 WebKit Commit Bot 2019-03-08 11:01:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-08 11:04:38 PST
<rdar://problem/48718522>