Bug 195457
| Summary: | [GTK] Several DNSTests are crashing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Diego Pino
Several DNS tests are crashing (https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/9929/steps/API%20tests/logs/stdio):
```
Unexpected crashes (3)
/WebCore/TestWebCore
DNSTest.cannotResolveDNS
DNSTest.cancelResolveDNS
DNSTest.resolveDNS
```
I looked into this issue and it seems the tests crash when attempting to access `soupNetworkSession()` (globalDefaultNetworkStorageSessionAccessor()().soupNetworkSession()). For instance:
https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp#L95
https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp#L187
I don't know when the tests stopped working. The earliest build tests results I could get were from r240433 and the tests were already crashing by then:
https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/9480/steps/API%20tests/logs/stdio
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Diego Pino
DNSResolveQueueSoup.cpp is no longer part of the codebase.