Bug 19545

Summary:

use PassRefPtr, not RefPtr, for return values

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Trivial

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch	sam: review+

Darin Adler

Reported 2008-06-14 00:44:48 PDT

I noticed some places where RefPtr was used for a function return value.

Attachments
patch (9.54 KB, patch) 2008-06-14 00:47 PDT, Darin Adler	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2008-06-14 00:47:07 PDT

Created attachment 21697 [details] patch

Adam Roben (:aroben)

Comment 2 2008-06-14 08:44:01 PDT

Comment on attachment 21697 [details] patch There are changes to 4 functions in XSLTProcessor.h, but to only 3 functions in XSLTProcessor.cpp. Why is that?

Darin Adler

Comment 3 2008-06-14 10:19:26 PDT

(In reply to comment #2) > (From update of attachment 21697 [details] [edit]) > There are changes to 4 functions in XSLTProcessor.h, but to only 3 functions in > XSLTProcessor.cpp. Why is that? Because documentFromXMLDocPtr is declared in the header, but never defined. I'll just remove its declaration.

Sam Weinig

Comment 4 2008-06-14 18:11:11 PDT

Comment on attachment 21697 [details] patch Gaa! // Convert a libxml doc ptr to a KHTML DOM Document r=me

Darin Adler

Comment 5 2008-06-14 21:33:19 PDT

Committed revision 34551.

Note You need to log in before you can comment on or make changes to this bug.