Bug 195409

Summary: Set window.closed immediately when close() is invoked
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ews-watchlist, ggaren, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/#dom-window-close
Bug Depends on: 196379    
Bug Blocks: 195406    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews103 for mac-highsierra
none
Archive of layout-test-results from ews106 for mac-highsierra-wk2
none
Archive of layout-test-results from ews114 for mac-highsierra
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch none

Comment 1 Chris Dumez 2019-03-28 16:45:13 PDT
Created attachment 366222 [details]
Patch
Comment 2 Chris Dumez 2019-03-28 20:09:28 PDT
Created attachment 366237 [details]
Patch
Comment 3 EWS Watchlist 2019-03-28 21:13:12 PDT
Comment on attachment 366237 [details]
Patch

Attachment 366237 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11698318

New failing tests:
imported/w3c/web-platform-tests/html/browsers/the-window-object/self-et-al.window.html
Comment 4 EWS Watchlist 2019-03-28 21:13:14 PDT
Created attachment 366242 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 5 EWS Watchlist 2019-03-28 21:27:38 PDT
Comment on attachment 366237 [details]
Patch

Attachment 366237 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11698350

New failing tests:
imported/w3c/web-platform-tests/html/browsers/the-window-object/self-et-al.window.html
Comment 6 EWS Watchlist 2019-03-28 21:27:40 PDT
Created attachment 366244 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 7 EWS Watchlist 2019-03-28 22:03:16 PDT
Comment on attachment 366237 [details]
Patch

Attachment 366237 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11698400

New failing tests:
imported/w3c/web-platform-tests/html/browsers/the-window-object/self-et-al.window.html
Comment 8 EWS Watchlist 2019-03-28 22:03:18 PDT
Created attachment 366248 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 9 EWS Watchlist 2019-03-28 22:15:23 PDT
Comment on attachment 366237 [details]
Patch

Attachment 366237 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11698418

New failing tests:
imported/w3c/web-platform-tests/html/browsers/the-window-object/self-et-al.window.html
Comment 10 EWS Watchlist 2019-03-28 22:15:25 PDT
Created attachment 366250 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 11 Chris Dumez 2019-03-29 09:05:03 PDT
Created attachment 366275 [details]
Patch
Comment 12 Chris Dumez 2019-03-29 13:47:04 PDT
Comment on attachment 366275 [details]
Patch

Clearing flags on attachment: 366275

Committed r243661: <https://trac.webkit.org/changeset/243661>
Comment 13 Chris Dumez 2019-03-29 13:47:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2019-03-29 13:48:26 PDT
<rdar://problem/49433379>