Bug 195406

Summary: Make someWindow.frames, .self, .window always return someWindow
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, cdumez, cgarcia, commit-queue, esprehn+autocc, ews-watchlist, ggaren, gustavo, kondapallykalyan, ljharb, mcatanzaro, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 195409    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Anne van Kesteren
Reported 2019-03-07 05:18:34 PST
Currently they no longer do once the browsing context goes away. I was initially inclined to endorse that model as it'd be one less reference to store on the global/realm, but given globalThis already does that it now seems pointless. HTML: https://github.com/whatwg/html/pull/4410 wpt: https://github.com/web-platform-tests/wpt/pull/15720
Attachments
Patch (10.66 KB, patch)
2019-03-29 10:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.69 KB, patch)
2019-03-29 13:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.81 KB, patch)
2019-03-29 15:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-03-29 10:11:37 PDT
Created attachment 366279 [details] Patch
Chris Dumez
Comment 2 2019-03-29 13:48:11 PDT
Created attachment 366305 [details] Patch
Alex Christensen
Comment 3 2019-03-29 14:56:45 PDT
Comment on attachment 366305 [details] Patch Looks like WebKitDOMDOMWindow.cpp needs to change to use globalThis too.
Chris Dumez
Comment 4 2019-03-29 15:00:33 PDT
Created attachment 366307 [details] Patch
EWS Watchlist
Comment 5 2019-03-29 15:02:23 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 6 2019-03-29 17:21:36 PDT
Comment on attachment 366307 [details] Patch Clearing flags on attachment: 366307 Committed r243669: <https://trac.webkit.org/changeset/243669>
WebKit Commit Bot
Comment 7 2019-03-29 17:21:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-29 17:22:18 PDT
<rdar://problem/49441638>
Note You need to log in before you can comment on or make changes to this bug.