Bug 195406

Summary: Make someWindow.frames, .self, .window always return someWindow
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, berto, cdumez, cgarcia, commit-queue, esprehn+autocc, ews-watchlist, ggaren, gustavo, kondapallykalyan, ljharb, mcatanzaro, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 195409    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Anne van Kesteren 2019-03-07 05:18:34 PST 
Currently they no longer do once the browsing context goes away. I was initially inclined to endorse that model as it'd be one less reference to store on the global/realm, but given globalThis already does that it now seems pointless.

HTML: https://github.com/whatwg/html/pull/4410

wpt: https://github.com/web-platform-tests/wpt/pull/15720
Comment 1 Chris Dumez 2019-03-29 10:11:37 PDT 
Created attachment 366279 [details]
Patch
Comment 2 Chris Dumez 2019-03-29 13:48:11 PDT 
Created attachment 366305 [details]
Patch
Comment 3 Alex Christensen 2019-03-29 14:56:45 PDT 
Comment on attachment 366305 [details]
Patch

Looks like WebKitDOMDOMWindow.cpp needs to change to use globalThis too.
Comment 4 Chris Dumez 2019-03-29 15:00:33 PDT 
Created attachment 366307 [details]
Patch
Comment 5 EWS Watchlist 2019-03-29 15:02:23 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 6 WebKit Commit Bot 2019-03-29 17:21:36 PDT 
Comment on attachment 366307 [details]
Patch

Clearing flags on attachment: 366307

Committed r243669: <https://trac.webkit.org/changeset/243669>
Comment 7 WebKit Commit Bot 2019-03-29 17:21:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-29 17:22:18 PDT 
<rdar://problem/49441638>