Summary: | Make someWindow.frames, .self, .window always return someWindow | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anne van Kesteren <annevk> | ||||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, berto, cdumez, cgarcia, commit-queue, esprehn+autocc, ews-watchlist, ggaren, gustavo, kondapallykalyan, ljharb, mcatanzaro, rniwa, sam, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 195409 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Anne van Kesteren
2019-03-07 05:18:34 PST
Created attachment 366279 [details]
Patch
Created attachment 366305 [details]
Patch
Comment on attachment 366305 [details]
Patch
Looks like WebKitDOMDOMWindow.cpp needs to change to use globalThis too.
Created attachment 366307 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 366307 [details] Patch Clearing flags on attachment: 366307 Committed r243669: <https://trac.webkit.org/changeset/243669> All reviewed patches have been landed. Closing bug. |