Bug 195400

Summary:

Web Inspector: Overlay: remove iOS specific paths in favor of a unified approach

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

NEW

Severity:

Normal

CC:

dbates, ews-watchlist, hi, inspector-bugzilla-changes, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

105023

Bug Blocks:

Attachments:

Description	Flags
[Patch] WIP	none
Patch	timothy: review-, hi: commit-queue-
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none

Devin Rousso

Reported 2019-03-06 23:24:06 PST

We currently only show than content/padding/margin/border highlights on iOS (e.g. no node information) :(

Attachments
[Patch] WIP (216.02 KB, patch) 2019-03-07 00:11 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (216.68 KB, patch) 2019-03-08 14:54 PST, Devin Rousso	timothy: review- hi: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.52 MB, application/zip) 2019-03-09 04:03 PST, EWS Watchlist	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-06 23:30:29 PST

<rdar://problem/48666991>

Devin Rousso

Comment 2 2019-03-07 00:11:13 PST

Created attachment 363853 [details] [Patch] WIP

Devin Rousso

Comment 3 2019-03-08 14:54:17 PST

Created attachment 364072 [details] Patch

EWS Watchlist

Comment 4 2019-03-09 04:03:42 PST Comment hidden (obsolete)

Comment on attachment 364072 [details] Patch Attachment 364072 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11437909 New failing tests: accessibility/mac/selection-notification-focus-change.html

EWS Watchlist

Comment 5 2019-03-09 04:03:43 PST Comment hidden (obsolete)

Created attachment 364126 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Devin Rousso

Comment 6 2019-03-11 21:43:21 PDT

Comment on attachment 364072 [details] Patch After some testing, there is an issue when zooming in on an iOS device (the PageOverlay zooms with the content, rather than staying the size of the view).

Timothy Hatcher

Comment 7 2019-03-20 09:28:19 PDT

Comment on attachment 364072 [details] Patch r- for now while you look into the issue.

Devin Rousso

Comment 8 2022-10-21 15:36:24 PDT

*** Bug 193205 has been marked as a duplicate of this bug. ***

Devin Rousso

Comment 9 2022-10-31 12:56:12 PDT

<rdar://problem/101515802>

Devin Rousso

Comment 10 2022-10-31 13:00:48 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5970

Note You need to log in before you can comment on or make changes to this bug.