195400 – Web Inspector: Overlay: remove iOS specific paths in favor of a unified approach

Bug 195400 - Web Inspector: Overlay: remove iOS specific paths in favor of a unified approach

Summary: Web Inspector: Overlay: remove iOS specific paths in favor of a unified approach

Status:	NEW

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Devin Rousso

URL:
Keywords:	InRadar

Duplicates (1):	193205 (view as bug list)
Depends on:	105023
Blocks:
	Show dependency tree / graph

Reported:	2019-03-06 23:24 PST by Devin Rousso
Modified:	2022-10-31 13:00 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
[Patch] WIP (216.02 KB, patch) 2019-03-07 00:11 PST, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Patch (216.68 KB, patch) 2019-03-08 14:54 PST, Devin Rousso	timothy: review- hi: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.52 MB, application/zip) 2019-03-09 04:03 PST, EWS Watchlist	no flags	Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Devin Rousso 2019-03-06 23:24:06 PST

We currently only show than content/padding/margin/border highlights on iOS (e.g. no node information) :(

Comment 1 Radar WebKit Bug Importer 2019-03-06 23:30:29 PST

<rdar://problem/48666991>

Comment 2 Devin Rousso 2019-03-07 00:11:13 PST

Created attachment 363853 [details]
[Patch] WIP

Comment 3 Devin Rousso 2019-03-08 14:54:17 PST

Created attachment 364072 [details]
Patch

Comment 4 EWS Watchlist 2019-03-09 04:03:42 PST Comment hidden (obsolete)

Comment on attachment 364072 [details]
Patch

Attachment 364072 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11437909

New failing tests:
accessibility/mac/selection-notification-focus-change.html

Comment 5 EWS Watchlist 2019-03-09 04:03:43 PST Comment hidden (obsolete)

Created attachment 364126 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 6 Devin Rousso 2019-03-11 21:43:21 PDT

Comment on attachment 364072 [details]
Patch

After some testing, there is an issue when zooming in on an iOS device (the PageOverlay zooms with the content, rather than staying the size of the view).

Comment 7 Timothy Hatcher 2019-03-20 09:28:19 PDT

Comment on attachment 364072 [details]
Patch

r- for now while you look into the issue.

Comment 8 Devin Rousso 2022-10-21 15:36:24 PDT

*** Bug 193205 has been marked as a duplicate of this bug. ***

Comment 9 Devin Rousso 2022-10-31 12:56:12 PDT

<rdar://problem/101515802>

Comment 10 Devin Rousso 2022-10-31 13:00:48 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5970