Bug 195391

Summary: Remove an unneeded assert that was added with r242113
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric.carlson, jer.noble, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2019-03-06 17:38:32 PST
This assertion failure is seen with multiple layout tests after it was added in https://trac.webkit.org/changeset/242113/webkit ASSERTION FAILED: m_mediaBufferingIsSuspended ./page/Page.cpp(1784) : void WebCore::Page::resumeAllMediaBuffering() 1 0x493aeaee9 WTFCrash 2 0x497bb9c5b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x49a78750b WebCore::Page::resumeAllMediaBuffering() 4 0x102bea184 WebKit::WebPage::resumeAllMediaBuffering() 5 0x1028a83a6 WebKit::WebProcess::resumeAllMediaBuffering() 6 0x1028a8e2a WebKit::WebProcess::processDidResume() see: https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r242569%20(2612)/results.html It doesn't seem necessary since m_mediaBufferingIsSuspended is protected by an 'if' statement right below the ASSERT: void Page::resumeAllMediaBuffering() { #if ENABLE(VIDEO) ASSERT(m_mediaBufferingIsSuspended); if (!m_mediaBufferingIsSuspended) return; ...
Attachments
Patch (1.39 KB, patch)
2019-03-06 17:44 PST, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2019-03-06 17:44:28 PST
Created attachment 363827 [details] Patch
Ryan Haddad
Comment 2 2019-03-06 17:54:02 PST
<rdar://48642781>
Radar WebKit Bug Importer
Comment 3 2019-03-06 17:54:17 PST
<rdar://problem/48660996>
WebKit Commit Bot
Comment 4 2019-03-06 19:03:27 PST
Comment on attachment 363827 [details] Patch Clearing flags on attachment: 363827 Committed r242586: <https://trac.webkit.org/changeset/242586>
WebKit Commit Bot
Comment 5 2019-03-06 19:03:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.