Bug 195382

Summary: [iOS] ProcessDidResume() IPC should be sent upon resuming when ProcessWillSuspendImminently() IPC was sent
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, jer.noble, koivisto, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 195416    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-03-06 15:03:33 PST
ProcessDidResume() IPC should be sent upon resuming when ProcessWillSuspendImminently() IPC was sent. Currently, we only send ProcessDidResume() to the WebProcess if PrepareToSuspend() was sent, not when the more urgent ProcessWillSuspendImminently() IPC was sent. This mismatch has lead to bugs because the WebProcess does not know it got resumed and failed to unfreeze the layers it froze upon suspension.
Attachments
Patch (10.07 KB, patch)
2019-03-06 15:55 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-03-06 15:04:32 PST
<rdar://problem/48642739>
Chris Dumez
Comment 2 2019-03-06 15:55:32 PST
Created attachment 363804 [details] Patch
Geoffrey Garen
Comment 3 2019-03-06 16:15:44 PST
Comment on attachment 363804 [details] Patch r=me
WebKit Commit Bot
Comment 4 2019-03-06 16:43:30 PST
Comment on attachment 363804 [details] Patch Clearing flags on attachment: 363804 Committed r242580: <https://trac.webkit.org/changeset/242580>
WebKit Commit Bot
Comment 5 2019-03-06 16:43:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.