Bug 195382 - [iOS] ProcessDidResume() IPC should be sent upon resuming when ProcessWillSuspendImminently() IPC was sent
Summary: [iOS] ProcessDidResume() IPC should be sent upon resuming when ProcessWillSus...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 195416
Blocks:
  Show dependency tree / graph
 
Reported: 2019-03-06 15:03 PST by Chris Dumez
Modified: 2019-03-07 10:31 PST (History)
6 users (show)

See Also:

Attachments
Patch (10.07 KB, patch)
2019-03-06 15:55 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-03-06 15:03:33 PST 
ProcessDidResume() IPC should be sent upon resuming when ProcessWillSuspendImminently() IPC was sent. Currently, we only send ProcessDidResume() to the WebProcess if PrepareToSuspend() was sent, not when the more urgent ProcessWillSuspendImminently() IPC was sent.

This mismatch has lead to bugs because the WebProcess does not know it got resumed and failed to unfreeze the layers it froze upon suspension.
Comment 1 Chris Dumez 2019-03-06 15:04:32 PST 
<rdar://problem/48642739>
Comment 2 Chris Dumez 2019-03-06 15:55:32 PST 
Created attachment 363804 [details]
Patch
Comment 3 Geoffrey Garen 2019-03-06 16:15:44 PST 
Comment on attachment 363804 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-03-06 16:43:30 PST 
Comment on attachment 363804 [details]
Patch

Clearing flags on attachment: 363804

Committed r242580: <https://trac.webkit.org/changeset/242580>
Comment 5 WebKit Commit Bot 2019-03-06 16:43:32 PST 
All reviewed patches have been landed.  Closing bug.