Bug 195353

Summary: [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2019-03-05 20:21:39 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2019-03-05 20:22:22 PST 
<rdar://problem/48626394>
Comment 2 zalan 2019-03-05 20:33:43 PST 
Created attachment 363728 [details]
Patch
Comment 3 zalan 2019-03-05 22:08:46 PST 
Created attachment 363732 [details]
Patch
Comment 4 zalan 2019-03-05 22:11:01 PST 
Created attachment 363733 [details]
Patch
Comment 5 zalan 2019-03-05 22:14:08 PST 
Created attachment 363734 [details]
Patch
Comment 6 zalan 2019-03-07 09:20:39 PST 
Created attachment 363883 [details]
Patch
Comment 7 Simon Fraser (smfr) 2019-03-07 11:24:47 PST 
Comment on attachment 363883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363883&action=review

> Source/WebCore/page/Settings.yaml:450
> +  initial: true

Follow defaultTextAutosizingEnabled().

> Source/WebCore/testing/InternalSettings.cpp:303
> +    settings().setContentChangeObserverEnabled(false);

I think this is wrong.

> Source/WebKit/Shared/WebPreferences.yaml:489
> +  defaultValue: true

Like WebCore::Settings::defaultTextAutosizingEnabled()
Comment 8 zalan 2019-03-07 14:21:49 PST 
Created attachment 363927 [details]
Patch
Comment 9 Simon Fraser (smfr) 2019-03-07 14:30:23 PST 
Comment on attachment 363927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363927&action=review

> Source/WebCore/page/Settings.yaml:450
> +  initial: true

Do like   initial: defaultSmartInsertDeleteEnabled
Comment 10 zalan 2019-03-07 15:13:17 PST 
Created attachment 363939 [details]
Patch
Comment 11 WebKit Commit Bot 2019-03-07 16:36:49 PST 
Comment on attachment 363939 [details]
Patch

Clearing flags on attachment: 363939

Committed r242621: <https://trac.webkit.org/changeset/242621>
Comment 12 WebKit Commit Bot 2019-03-07 16:36:51 PST 
All reviewed patches have been landed.  Closing bug.