RESOLVED FIXED 195353
[ContentChangeObserver] Add a setting to be able to turn content change observation on/off 
https://bugs.webkit.org/show_bug.cgi?id=195353
Summary [ContentChangeObserver] Add a setting to be able to turn content change obser...
zalan
Reported 2019-03-05 20:21:39 PST
ssia
Attachments
Patch (43.62 KB, patch)
2019-03-05 20:33 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (23.16 KB, patch)
2019-03-05 22:08 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (23.16 KB, patch)
2019-03-05 22:11 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (16.16 KB, patch)
2019-03-05 22:14 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (43.58 KB, patch)
2019-03-07 09:20 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (42.99 KB, patch)
2019-03-07 14:21 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (44.25 KB, patch)
2019-03-07 15:13 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-05 20:22:22 PST
<rdar://problem/48626394>
zalan
Comment 2 2019-03-05 20:33:43 PST
Created attachment 363728 [details] Patch
zalan
Comment 3 2019-03-05 22:08:46 PST
Created attachment 363732 [details] Patch
zalan
Comment 4 2019-03-05 22:11:01 PST
Created attachment 363733 [details] Patch
zalan
Comment 5 2019-03-05 22:14:08 PST
Created attachment 363734 [details] Patch
zalan
Comment 6 2019-03-07 09:20:39 PST
Created attachment 363883 [details] Patch
Simon Fraser (smfr)
Comment 7 2019-03-07 11:24:47 PST
Comment on attachment 363883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363883&action=review > Source/WebCore/page/Settings.yaml:450 > + initial: true Follow defaultTextAutosizingEnabled(). > Source/WebCore/testing/InternalSettings.cpp:303 > + settings().setContentChangeObserverEnabled(false); I think this is wrong. > Source/WebKit/Shared/WebPreferences.yaml:489 > + defaultValue: true Like WebCore::Settings::defaultTextAutosizingEnabled()
zalan
Comment 8 2019-03-07 14:21:49 PST
Created attachment 363927 [details] Patch
Simon Fraser (smfr)
Comment 9 2019-03-07 14:30:23 PST
Comment on attachment 363927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363927&action=review > Source/WebCore/page/Settings.yaml:450 > + initial: true Do like initial: defaultSmartInsertDeleteEnabled
zalan
Comment 10 2019-03-07 15:13:17 PST
Created attachment 363939 [details] Patch
WebKit Commit Bot
Comment 11 2019-03-07 16:36:49 PST
Comment on attachment 363939 [details] Patch Clearing flags on attachment: 363939 Committed r242621: <https://trac.webkit.org/changeset/242621>
WebKit Commit Bot
Comment 12 2019-03-07 16:36:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.