Bug 195339

Summary: op_switch_char broken for rope strings after JSRopeString layout rewrite
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
ysuzuki: review+
patch for landing none

Description Saam Barati 2019-03-05 13:18:46 PST 
...
Comment 1 Saam Barati 2019-03-05 13:19:59 PST 
<rdar://problem/48592545>
Comment 2 Saam Barati 2019-03-05 13:24:57 PST 
Created attachment 363680 [details]
patch
Comment 3 Saam Barati 2019-03-05 13:26:15 PST 
Created attachment 363681 [details]
patch
Comment 4 Yusuke Suzuki 2019-03-05 13:29:45 PST 
Comment on attachment 363681 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363681&action=review

r=me with a comment.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1792
>      loadp JSString::m_fiber[t0], t0

Why not using `t1` for fiber0? Then, I think we do not need to add `move`.
Comment 5 Saam Barati 2019-03-05 14:39:10 PST 
Created attachment 363691 [details]
patch for landing
Comment 6 WebKit Commit Bot 2019-03-05 16:20:13 PST 
Comment on attachment 363691 [details]
patch for landing

Clearing flags on attachment: 363691

Committed r242519: <https://trac.webkit.org/changeset/242519>
Comment 7 WebKit Commit Bot 2019-03-05 16:20:14 PST 
All reviewed patches have been landed.  Closing bug.