Bug 195339

Summary: op_switch_char broken for rope strings after JSRopeString layout rewrite
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
ysuzuki: review+
patch for landing none

Saam Barati
Reported 2019-03-05 13:18:46 PST
...
Attachments
patch (4.93 KB, patch)
2019-03-05 13:24 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (4.94 KB, patch)
2019-03-05 13:26 PST, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing (5.54 KB, patch)
2019-03-05 14:39 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-03-05 13:19:59 PST
<rdar://problem/48592545>
Saam Barati
Comment 2 2019-03-05 13:24:57 PST
Created attachment 363680 [details] patch
Saam Barati
Comment 3 2019-03-05 13:26:15 PST
Created attachment 363681 [details] patch
Yusuke Suzuki
Comment 4 2019-03-05 13:29:45 PST
Comment on attachment 363681 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=363681&action=review r=me with a comment. > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1792 > loadp JSString::m_fiber[t0], t0 Why not using `t1` for fiber0? Then, I think we do not need to add `move`.
Saam Barati
Comment 5 2019-03-05 14:39:10 PST
Created attachment 363691 [details] patch for landing
WebKit Commit Bot
Comment 6 2019-03-05 16:20:13 PST
Comment on attachment 363691 [details] patch for landing Clearing flags on attachment: 363691 Committed r242519: <https://trac.webkit.org/changeset/242519>
WebKit Commit Bot
Comment 7 2019-03-05 16:20:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.