| Summary: | MockLibWebRTCPeerConnection is leaking some session description | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ddkilzer, eric.carlson, ews-watchlist, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2019-03-04 22:40:19 PST
Created attachment 363606 [details]
Patch
Comment on attachment 363606 [details] Patch Attachment 363606 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11374442 New failing tests: fast/scrolling/ios/hit-testing-iframe-003.html Created attachment 363621 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 363606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363606&action=review r=me > Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:214 > +void MockLibWebRTCPeerConnection::SetLocalDescription(webrtc::SetSessionDescriptionObserver* observer, webrtc::SessionDescriptionInterface* description) Nit: Use `sessionDescription` like SetRemoteDescription()? Created attachment 363674 [details]
Patch for landing
Comment on attachment 363674 [details] Patch for landing Clearing flags on attachment: 363674 Committed r242506: <https://trac.webkit.org/changeset/242506> All reviewed patches have been landed. Closing bug. |