Bug 195315

Summary: MockLibWebRTCPeerConnection is leaking some session description
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch for landing none

youenn fablet
Reported 2019-03-04 22:40:19 PST
MockLibWebRTCPeerConnection is leaking some session description
Attachments
Patch (3.11 KB, patch)
2019-03-04 22:43 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (1.66 MB, application/zip)
2019-03-05 01:37 PST, EWS Watchlist 		no flags
Details
Patch for landing (3.16 KB, patch)
2019-03-05 13:13 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-03-04 22:40:37 PST
<rdar://problem/47840038>
youenn fablet
Comment 2 2019-03-04 22:43:19 PST
Created attachment 363606 [details] Patch
EWS Watchlist
Comment 3 2019-03-05 01:37:49 PST
Comment on attachment 363606 [details] Patch Attachment 363606 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11374442 New failing tests: fast/scrolling/ios/hit-testing-iframe-003.html
EWS Watchlist
Comment 4 2019-03-05 01:37:50 PST
Created attachment 363621 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
David Kilzer (:ddkilzer)
Comment 5 2019-03-05 02:05:04 PST
Comment on attachment 363606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363606&action=review r=me > Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:214 > +void MockLibWebRTCPeerConnection::SetLocalDescription(webrtc::SetSessionDescriptionObserver* observer, webrtc::SessionDescriptionInterface* description) Nit: Use `sessionDescription` like SetRemoteDescription()?
youenn fablet
Comment 6 2019-03-05 13:13:26 PST
Created attachment 363674 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-03-05 13:49:47 PST
Comment on attachment 363674 [details] Patch for landing Clearing flags on attachment: 363674 Committed r242506: <https://trac.webkit.org/changeset/242506>
WebKit Commit Bot
Comment 8 2019-03-05 13:49:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.