Bug 195315 - MockLibWebRTCPeerConnection is leaking some session description
Summary: MockLibWebRTCPeerConnection is leaking some session description
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-04 22:40 PST by youenn fablet
Modified: 2019-03-05 13:49 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2019-03-04 22:43 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (1.66 MB, application/zip)
2019-03-05 01:37 PST, Build Bot
no flags Details
Patch for landing (3.16 KB, patch)
2019-03-05 13:13 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-03-04 22:40:19 PST
MockLibWebRTCPeerConnection is leaking some session description
Comment 1 youenn fablet 2019-03-04 22:40:37 PST
<rdar://problem/47840038>
Comment 2 youenn fablet 2019-03-04 22:43:19 PST
Created attachment 363606 [details]
Patch
Comment 3 Build Bot 2019-03-05 01:37:49 PST
Comment on attachment 363606 [details]
Patch

Attachment 363606 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11374442

New failing tests:
fast/scrolling/ios/hit-testing-iframe-003.html
Comment 4 Build Bot 2019-03-05 01:37:50 PST
Created attachment 363621 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 David Kilzer (:ddkilzer) 2019-03-05 02:05:04 PST
Comment on attachment 363606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363606&action=review

r=me

> Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:214
> +void MockLibWebRTCPeerConnection::SetLocalDescription(webrtc::SetSessionDescriptionObserver* observer, webrtc::SessionDescriptionInterface* description)

Nit: Use `sessionDescription` like SetRemoteDescription()?
Comment 6 youenn fablet 2019-03-05 13:13:26 PST
Created attachment 363674 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-03-05 13:49:47 PST
Comment on attachment 363674 [details]
Patch for landing

Clearing flags on attachment: 363674

Committed r242506: <https://trac.webkit.org/changeset/242506>
Comment 8 WebKit Commit Bot 2019-03-05 13:49:49 PST
All reviewed patches have been landed.  Closing bug.