| Summary: | [bmalloc] Bmalloc DebugHeap should have dump and scavenge features | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 195316 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2019-03-04 19:40:55 PST
Created attachment 363584 [details]
Patch
Created attachment 363586 [details]
Patch
Comment on attachment 363586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review > Source/bmalloc/ChangeLog:9 > + We also add DebugHeap::dump feature which dumps system malloc data in the WebKit Malloc zone. This indirectly means that Mini mode VM + System Malloc does actually shrinking if shrinkFootprintWhenIdle is called. I would like to see this impact on the tests calling shrinkFootprintWhenIdle. Comment on attachment 363586 [details] Patch Attachment 363586 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11372478 New failing tests: fast/events/beforeunload-alert-user-interaction2.html fast/scrolling/ios/hit-testing-iframe-002.html fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html fast/events/click-handler-on-body-simple.html Created attachment 363603 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 363586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review > Source/bmalloc/bmalloc/DebugHeap.cpp:79 > + // Currently, |goal| does not affect on the result of malloc_zone_pressure_relief if we only scavenge one zone. I don't follow what you mean by "result" here. Comment on attachment 363586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review >> Source/bmalloc/bmalloc/DebugHeap.cpp:79 >> + // Currently, |goal| does not affect on the result of malloc_zone_pressure_relief if we only scavenge one zone. > > I don't follow what you mean by "result" here. The resulted effect by malloc_zone_pressure_relief. As long as it is not nano-malloc, the logic does not change with this |goal| value now. (https://opensource.apple.com/source/libmalloc/libmalloc-166.220.1/src/magazine_malloc.c.auto.html's szone_pressure_relief). I'll rephrase this part. Committed r242507: <https://trac.webkit.org/changeset/242507> |