Bug 195305 – [bmalloc] Bmalloc DebugHeap should have dump and scavenge features

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[bmalloc] Bmalloc DebugHeap should have dump and scavenge features

[Yusuke Suzuki]

Created attachment 363584 [details]
Patch

[Yusuke Suzuki]

Created attachment 363586 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 363586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review

> Source/bmalloc/ChangeLog:9
> +        We also add DebugHeap::dump feature which dumps system malloc data in the WebKit Malloc zone.

This indirectly means that Mini mode VM + System Malloc does actually shrinking if shrinkFootprintWhenIdle is called.
I would like to see this impact on the tests calling shrinkFootprintWhenIdle.

[EWS Watchlist]

Comment on attachment 363586 [details]
Patch

Attachment 363586 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11372478

New failing tests:
fast/events/beforeunload-alert-user-interaction2.html
fast/scrolling/ios/hit-testing-iframe-002.html
fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html
fast/events/click-handler-on-body-simple.html

[EWS Watchlist]

Created attachment 363603 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Saam Barati]

Comment on attachment 363586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review

> Source/bmalloc/bmalloc/DebugHeap.cpp:79
> +    // Currently, |goal| does not affect on the result of malloc_zone_pressure_relief if we only scavenge one zone.

I don't follow what you mean by "result" here.

[Yusuke Suzuki]

Comment on attachment 363586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review

>> Source/bmalloc/bmalloc/DebugHeap.cpp:79
>> +    // Currently, |goal| does not affect on the result of malloc_zone_pressure_relief if we only scavenge one zone.
> 
> I don't follow what you mean by "result" here.

The resulted effect by malloc_zone_pressure_relief. As long as it is not nano-malloc, the logic does not change with this |goal| value now. (https://opensource.apple.com/source/libmalloc/libmalloc-166.220.1/src/magazine_malloc.c.auto.html's szone_pressure_relief).
I'll rephrase this part.

[Yusuke Suzuki]

Committed r242507: <https://trac.webkit.org/changeset/242507>

[Radar WebKit Bug Importer]

<rdar://problem/48612690>