Bug 195305 - [bmalloc] Bmalloc DebugHeap should have dump and scavenge features
Summary: [bmalloc] Bmalloc DebugHeap should have dump and scavenge features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 195316
  Show dependency treegraph
 
Reported: 2019-03-04 19:40 PST by Yusuke Suzuki
Modified: 2019-03-05 13:50 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.84 KB, patch)
2019-03-04 19:43 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (2.96 KB, patch)
2019-03-04 19:45 PST, Yusuke Suzuki
sbarati: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (3.54 MB, application/zip)
2019-03-04 22:35 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-04 19:40:55 PST
[bmalloc] Bmalloc DebugHeap should have dump and scavenge features
Comment 1 Yusuke Suzuki 2019-03-04 19:43:37 PST
Created attachment 363584 [details]
Patch
Comment 2 Yusuke Suzuki 2019-03-04 19:45:56 PST
Created attachment 363586 [details]
Patch
Comment 3 Yusuke Suzuki 2019-03-04 20:26:40 PST
Comment on attachment 363586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review

> Source/bmalloc/ChangeLog:9
> +        We also add DebugHeap::dump feature which dumps system malloc data in the WebKit Malloc zone.

This indirectly means that Mini mode VM + System Malloc does actually shrinking if shrinkFootprintWhenIdle is called.
I would like to see this impact on the tests calling shrinkFootprintWhenIdle.
Comment 4 EWS Watchlist 2019-03-04 22:35:24 PST
Comment on attachment 363586 [details]
Patch

Attachment 363586 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11372478

New failing tests:
fast/events/beforeunload-alert-user-interaction2.html
fast/scrolling/ios/hit-testing-iframe-002.html
fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html
fast/events/click-handler-on-body-simple.html
Comment 5 EWS Watchlist 2019-03-04 22:35:26 PST
Created attachment 363603 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 6 Saam Barati 2019-03-05 10:58:15 PST
Comment on attachment 363586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review

> Source/bmalloc/bmalloc/DebugHeap.cpp:79
> +    // Currently, |goal| does not affect on the result of malloc_zone_pressure_relief if we only scavenge one zone.

I don't follow what you mean by "result" here.
Comment 7 Yusuke Suzuki 2019-03-05 11:19:35 PST
Comment on attachment 363586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363586&action=review

>> Source/bmalloc/bmalloc/DebugHeap.cpp:79
>> +    // Currently, |goal| does not affect on the result of malloc_zone_pressure_relief if we only scavenge one zone.
> 
> I don't follow what you mean by "result" here.

The resulted effect by malloc_zone_pressure_relief. As long as it is not nano-malloc, the logic does not change with this |goal| value now. (https://opensource.apple.com/source/libmalloc/libmalloc-166.220.1/src/magazine_malloc.c.auto.html's szone_pressure_relief).
I'll rephrase this part.
Comment 8 Yusuke Suzuki 2019-03-05 13:49:50 PST
Committed r242507: <https://trac.webkit.org/changeset/242507>
Comment 9 Radar WebKit Bug Importer 2019-03-05 13:50:30 PST
<rdar://problem/48612690>