| Summary: | [ContentChangeObserver] Move away from WKContentChange values | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2019-03-01 21:08:03 PST
Created attachment 363409 [details]
Patch
Comment on attachment 363409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363409&action=review > Source/WebCore/ChangeLog:9 > + This is in preparation for moving towards a state machine like implementation. state machine-like > Source/WebCore/page/ios/ContentChangeObserver.cpp:133 > + LOG(ContentObservation, "stopObservingStyleRecalc: notify the pending synthetic click handler."); Mentioning synthetic clicks here indicates a layering problem, as we talked about. > Source/WebCore/page/ios/ContentChangeObserver.cpp:137 > + LOG(ContentObservation, "stopObservingStyleRecalc: can't decided it yet."); "can't decided it" ? > Source/WebCore/page/ios/ContentChangeObserver.cpp:193 > +bool ContentChangeObserver::hasDeterminedState() const So "determined" as an adjective means "intent on" as in "he was very determined". This should use "determinate", meaning "fixed" or "settled". Committed r242319: <https://trac.webkit.org/changeset/242319> |