| Summary: | [JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2019-03-01 16:57:35 PST
Created attachment 363390 [details]
Patch
Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review > Source/JavaScriptCore/runtime/JSString.h:567 > + static ptrdiff_t offsetOfFlags() { return 0; } > + static ptrdiff_t offsetOfFiber1Lower() { return 0; } > + static ptrdiff_t offsetOfFiber1Upper() { return 0; } > + static ptrdiff_t offsetOfFiber2Lower() { return 0; } > + static ptrdiff_t offsetOfFiber2Upper() { return 0; } please ASSERT_NOT_REACHED or similar. Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review >> Source/JavaScriptCore/runtime/JSString.h:567 >> + static ptrdiff_t offsetOfFiber2Upper() { return 0; } > > please ASSERT_NOT_REACHED or similar. Nice! Added. Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review > Source/JavaScriptCore/runtime/JSString.h:560 > + // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString, /stroing/storing/ Comment on attachment 363390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review >> Source/JavaScriptCore/runtime/JSString.h:560 >> + // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString, > > /stroing/storing/ Oops, nice catch. Fixed. Committed r242299: <https://trac.webkit.org/changeset/242299> |