Summary: | [ContentChangeObserver] Check for pending style recalcs at the end of each timer run. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2019-03-01 12:17:55 PST
Created attachment 363362 [details]
Patch
Comment on attachment 363362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363362&action=review > Source/WebCore/ChangeLog:10 > + when in addition to this style recalc scheduling, something later (thouhg during the same timer firing) triggers a sync style recalc. thouhg > Source/WebCore/page/ios/ContentChangeObserver.cpp:99 > + auto inDeterminedState = observedContentChange == WKContentVisibilityChange || (!countOfObservedDOMTimers() && observedContentChange == WKContentNoChange && !hasPendingStyleRecalc); hasDeterminedState Comment on attachment 363362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363362&action=review > LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:33 > + document.body.offsetHeight; Doesn't seem necessary. > LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:34 > + testRunner.dumpAsText(); Normally we do this at the start > LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:37 > + }, 100); Fix this. Created attachment 363364 [details]
Patch
Comment on attachment 363364 [details] Patch Clearing flags on attachment: 363364 Committed r242290: <https://trac.webkit.org/changeset/242290> All reviewed patches have been landed. Closing bug. |