Bug 195220 – [ContentChangeObserver] Check for pending style recalcs at the end of each timer run.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

instead of relying on didScheduleStyleRecalc since style recalc scheduling can turn into sync style recalcs.

[Radar WebKit Bug Importer]

<rdar://problem/48518979>

[zalan]

Created attachment 363362 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 363362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363362&action=review

> Source/WebCore/ChangeLog:10
> +        when in addition to this style recalc scheduling, something later (thouhg during the same timer firing) triggers a sync style recalc.

thouhg

> Source/WebCore/page/ios/ContentChangeObserver.cpp:99
> +    auto inDeterminedState = observedContentChange == WKContentVisibilityChange || (!countOfObservedDOMTimers() && observedContentChange == WKContentNoChange && !hasPendingStyleRecalc);  

hasDeterminedState

[Simon Fraser (smfr)]

Comment on attachment 363362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363362&action=review

> LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:33
> +            document.body.offsetHeight;

Doesn't seem necessary.

> LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:34
> +            testRunner.dumpAsText();

Normally we do this at the start

> LayoutTests/fast/events/touch/ios/style-recalc-schedule-and-force-relalc.html:37
> +    }, 100);

Fix this.

[zalan]

Created attachment 363364 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 363364 [details]
Patch

Clearing flags on attachment: 363364

Committed r242290: <https://trac.webkit.org/changeset/242290>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.