Bug 195215

Summary: Improper use of PLATFORM(TVOS) in PAL
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: PlatformAssignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, conrad_shultz, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Conrad Shultz
Reported 2019-03-01 09:45:09 PST
There are a couple stray uses of PLATFORM(TVOS) in PAL. The correct usage is PLATFORM(APPLETV).
Attachments
Patch (3.49 KB, patch)
2019-03-01 09:52 PST, Conrad Shultz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Conrad Shultz
Comment 1 2019-03-01 09:45:23 PST
<rdar://problem/48512402>
Conrad Shultz
Comment 2 2019-03-01 09:52:14 PST
Created attachment 363339 [details] Patch
Conrad Shultz
Comment 3 2019-03-01 09:53:37 PST
Style checker will fail due to existing issues, but I don't think we should address those as part of this change.
EWS Watchlist
Comment 4 2019-03-01 09:54:51 PST
Attachment 363339 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32: Incorrect OS version check. VERSION_MIN_REQUIRED values never include a minor version. You may be looking for a combination of VERSION_MIN_REQUIRED for target OS version check and VERSION_MAX_ALLOWED for SDK check. [build/version_check] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:34: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 5 2019-03-01 12:48:21 PST
You probably don't have to, but this is a good opportunity to improve things.
Conrad Shultz
Comment 6 2019-03-04 10:44:16 PST
(In reply to Alexey Proskuryakov from comment #5) > You probably don't have to, but this is a good opportunity to improve things. I'd like to do these in separate commits, in the unlikely event that addressing the style issues introduces unexpected problems.
Conrad Shultz
Comment 7 2019-03-04 11:58:55 PST
Committed r242368: <https://trac.webkit.org/changeset/242368>
Note You need to log in before you can comment on or make changes to this bug.