REGRESSION: (r242189): Seven Layout Tests in storage/indexeddb/ are crashing after r242189

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Truitt Savell]

The following layout tests are crashing on Mac Debug WK1

storage/indexeddb/intversion-open-in-upgradeneeded-private.html 
storage/indexeddb/intversion-open-in-upgradeneeded.html 
storage/indexeddb/modern/abort-requests-cancelled-private.html 
storage/indexeddb/modern/abort-requests-cancelled.html 
storage/indexeddb/modern/blocked-open-db-requests-private.html 
storage/indexeddb/odd-strings-private.html

Probable cause:

These tests began crashing after the rollout of https://trac.webkit.org/changeset/242014/webkit in https://trac.webkit.org/changeset/242189/webkit. Possibly some change was made that was dependent on 242014 before it was rolled out. Currently these tests are slowing down WK1 EWS. These tests are reproducible locally by just running these tests on a checkout of r242189. 

This is related to https://bugs.webkit.org/show_bug.cgi?id=195141

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fintversion-open-in-upgradeneeded-private.html%20storage%2Findexeddb%2Fintversion-open-in-upgradeneeded.html%20storage%2Findexeddb%2Fmodern%2Fabort-requests-cancelled-private.html%20storage%2Findexeddb%2Fmodern%2Fabort-requests-cancelled.html%20storage%2Findexeddb%2Fmodern%2Fblocked-open-db-requests-private.html%20storage%2Findexeddb%2Fodd-strings-private.html

[Truitt Savell]

Marked tests skip while investigating and to get EWS caught up: https://trac.webkit.org/changeset/242264/webkit

[Truitt Savell]

This additional test appears to be crashing often on EWS alone 
storage/indexeddb/modern/blocked-open-db-requests.html

https://webkit-queues.webkit.org/results/11334458

This is continuing to slow EWS

[Truitt Savell]

Skipped in: https://trac.webkit.org/changeset/242282/webkit

[Truitt Savell]

Crash:
https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r242199%20(8015)/storage/indexeddb/intversion-open-in-upgradeneeded-private-crash-log.txt

[Radar WebKit Bug Importer]

<rdar://problem/48523172>

[Truitt Savell]

It appears that after skipping some tests others begin to crash. I have not been able to narrow down which test is at fault for the crashes later in the test runner.

[Truitt Savell]

I talked with sihui and she found that https://trac.webkit.org/changeset/242075/webkit is calling a function from r242014 and is crashing due to the rollout. Looks like we will need to roll this change out too to resolve the crashing tests.

[Xabier Rodríguez Calvar]

(In reply to Truitt Savell from comment #7)
> I talked with sihui and she found that
> https://trac.webkit.org/changeset/242075/webkit is calling a function from
> r242014 and is crashing due to the rollout. Looks like we will need to roll
> this change out too to resolve the crashing tests.

No, you can't roll out my change. I didn't touch that function per-se. I just unveiled a hidden bug.

[Xabier Rodríguez Calvar]

Besides I don't know if this is still valid as it looks like there's r242308 landing that part of r242014

[Xabier Rodríguez Calvar]

And the link to the flakiness dashboard says they are green now, so I'd say we're cool here now.

[Xabier Rodríguez Calvar]

It was Darin, btw, who landed r242308.

[Truitt Savell]

Issue does appear to be resolved by r242308. I unskipped the tests in: https://trac.webkit.org/changeset/242358/webkit